Fix pickling auto_exc exceptions with kw_only fields - #1573
Closed
lin-hongkuan wants to merge 1 commit into
Closed
Conversation
Member
|
Thank you for trying to contribute. Given the current volume of LLM-assisted contributions, we cannot spend maintainer time reviewing pull requests that do not follow the project’s contribution process. Before submitting further contributions, please read and follow this project’s CONTRIBUTING.md and AI_POLICY.md. Thank you for your understanding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #734.
This adds an attrs-generated
__reduce__forauto_exc=Trueexception classes that haveinit=Truekeyword-only fields. The generated reducer reconstructs the exception without calling__init__, then restores the normal pickle state, so required keyword-only fields work across plain, frozen, slotted, and frozen-slotted exception classes.The generation is intentionally narrow: it only applies to attrs-generated exception
__init__methods with keyword-only init fields, leaves positional-only exceptions onBaseException.__reduce__, and does not override custom__reduce__implementations, including inherited ones.Tests
PYTHONPATH=src python -m pytest -qPYTHONPATH=src python -m ruff check src/attr/_make.py tests/test_functional.pyPYTHONPATH=src python -m ruff format --check src/attr/_make.py tests/test_functional.pygit diff --check